feat(amazonq): basic paginated suggestions using language server #6803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zixlin7
changed the title
zixlin7
force-pushed
the
pagination
branch
2 times, most recently
from
76d917b to
ba33860
Compare
| const swapProviderAndShow = async () => { | ||
| await commands.executeCommand('editor.action.inlineSuggest.hide') | ||
| this.disposable.dispose() | ||
| this.disposable = languages.registerInlineCompletionItemProvider( |
Contributor
There was a problem hiding this comment.
Does this still have the weird effect where the number of items shown in the inline completion don't get updated? I guess thats unavoidable though?
Contributor
Author
There was a problem hiding this comment.
yes it still has that issue and it's not avoidable unfortunately
packages/amazonq/test/unit/amazonq/apps/inline/completion.test.ts
Outdated
Show resolved
Hide resolved
Contributor
|
In terms of merging this, do we have to do it after the inline changes are released from the language servers side? Or can we do it now and it won't break anything? |
Contributor
Author
|
/retryBuilds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
Basic paginated inline suggestions implementation using language server (related: aws/language-servers#831)
feature/xbranches will not be squash-merged at release time.